Shopify / shopify-app-bridge

https://shopify.dev/docs/api/app-bridge
86 stars 9 forks source link

Embedded apps: filename on download attribute isn't respected #190

Open ascherkus opened 1 year ago

ascherkus commented 1 year ago

Describe the bug

In an embedded app having <a href="foo.txt" download="bar.txt"> appears to download the file as "foo.txt" as opposed to "bar.txt".

When accessing the same page in a browser as opposed to the embedded Shopify app, the file is downloaded as "bar.txt" as expected.

To Reproduce

Steps to reproduce the behaviour:

  1. Host an embedded app that has an <a href="..." download="..."> in it (note the href must be on the same origin
  2. Click on the link when in embedded app

Expected behaviour

The file is downloaded using the filename provided in the download attribute.

Contextual information

Packages and versions

Platform

Additional context

Add any other context about the problem here, such as your app’s configuration (Node, Next.js, Rails).