Shopify / shopify-app-bridge

https://shopify.dev/docs/api/app-bridge
86 stars 9 forks source link

App Bridge 3.7.9 Still Blow up on App took too long to load. Legacy blah #259

Closed resistorsoftware closed 9 months ago

resistorsoftware commented 9 months ago

It is still a thing a year later? This stupid internal Shopify bug about App Bridge not loading so let's scare the merchant and open two tabs and lalalalalala.

Way to go Javascript team Shopify! I do hope this effort earns some rewards. Awesome stuff there. Wonderful. See you in 2024 for the same old same old I bet. As we migrate ever so slowly to admin.shopify.com/stores and all our nice Apps puke over and over and over again on App Bridge! A bridge too far!

henrytao-me commented 9 months ago

@resistorsoftware May I have your appId please?

resistorsoftware commented 9 months ago

@henrytao-me gid://shopify/App/4003963

Would appreciate any insights as to why this App is getting that forced_legacy redirect when it is not doing anything but the right stuff AFAIK... same template App as many others I have and they are not exhibiting this behaviour.

henrytao-me commented 9 months ago

Hi @resistorsoftware, your app should be good now. The banner is gone.

For context, there are handful of old apps (I forgot the cut off date) that aren't compatible with the new admin which is why the banner is shown. After fixing the compatibility issue, partner needs to contact support team to resolve it unfortunately.

I am so sorry for the inconvenient. 🙇

resistorsoftware commented 9 months ago

I am not understanding the answer here. First off, is my App here in a "handful"? It is older yes, it was App Bridge 2. Secondly, this new App is compatible with new Shopify Admin through and through, so why was it flagged?

You tell me I have to fix a compatibility issue. What is that? Who to contact? It seems unfair to not fill me in on basic details here. If it is a well-known fix, what is it? Why is this App specifically a target when it is running state of the art code now?

Anyway.. OK.. thanks... if that banner is gone, problem is solved.

faridmovsumov commented 8 months ago

@henrytao-me, we have the same problem. The app id is 4222617. Could you please help?

henrytao-me commented 8 months ago

Done @faridmovsumov

wissem commented 4 months ago

@henrytao-me we have the same issue, could you please help? Issue is appearing on old created apps, but newly created one doesn't have it (although same code and same configuration). Our staging App ID: 5005323. Also probably I have the same issue on our live app which isn't embedded yet and created 5 years ago. Can I share the App ID for that one and you can update the settings without affecting existing users?

Thanks!

henrytao-me commented 4 months ago

@wissem Done 🙇

wissem commented 4 months ago

@henrytao-me this is working now, thank you 🙏 What about my live app? It's non-embedded right now, but we plan to make it embedded in a few weeks. In case enabling the flag woudln't break existing functionality for users, can you enable it for the live app too? App ID: 1870886

henrytao-me commented 4 months ago

Done too @wissem

lucahollandetempa commented 1 month ago

Hi there @henrytao-me ,

Just re-activating this thread because we have run into this issue with quite a few of our apps.

Most of our apps were set up as embedded apps before App Bridge was a requirement of embedded apps. They are all custom apps, rather than public ones.

I have a couple of questions: