search

Shopify / shopify-app-bridge

https://shopify.dev/docs/api/app-bridge
82 stars 9 forks source link

ui-modal height not fit content #295

Closed quocdatPTIT closed 4 months ago

quocdatPTIT commented 4 months ago

Describe the bug

The new <ui-modal /> component always renders with full height

To Reproduce

Steps to reproduce the behaviour:

  1. Add <ui-modal /> into code

  2. Open the modal

If applicable, add screenshots to help explain your problem. image

Expected behaviour

ui-modal height fit content image

Contextual information

Packages and versions

List the relevant packages you’re using, and their versions. For example:

coderlinbb commented 4 months ago

Me too.

skamarakas commented 4 months ago

same 😢

hamzasgd commented 4 months ago

This is what causing the issue modal issue

henrytao-me commented 4 months ago

It's fixed. Thanks for reporting the issue 🙇