Closed mirceapiturca closed 4 months ago
jzazove
commented
4 months ago The unfortunate part is that some apps were abusing Fullscreen leaving merchants lost. Some apps, for example, were not even implementing the Polaris Top Bar. We will look to adding more features to the max modal in the latest version of App Bridge.
alexdover
commented
4 months ago It is a real shame that the actions of the apps abusing have ended up spoiling the experience merchants get with apps doing the right thing.
From our point of view, it has really hurt our UI. We were really proud of our fullscreen editor and merchants loved it.
Would you consider allowing it for Built for Shopify apps?
jzazove
commented
4 months ago I understand your disappointment. The new fullscreen user experience does match the Polaris uplift now. Can you share what your fullscreen looked like? I'd love to see a screenshot or a GIF. .
mirceapiturca
commented
4 months ago The unfortunate part is that some apps were abusing Fullscreen leaving merchants lost. Some apps, for example, were not even implementing the Polaris Top Bar. We will look to adding more features to the max modal in the latest version of App Bridge.
Missue of the Fullscreen should be an issue for the app review team. The v4 Modal has many issues. Some Polaris components don't even work properly in the modal. Wrapping this in an iframe is also problematic. I don't see how merchants get lost. If this is the case, also not embedded apps should be canned.
alexdover
commented
4 months ago Absolutely, this is what it looks like.
We took inspiration from the theme editor. We are a Built for Shopify app too, hence why I selfishly thought that might be an option!
darrynten
commented
4 months ago On our side we also took inspiration from the theme editor and designed our Fullscreen experience to match. We put months into this.
I also agree that abuse of the Fullscreen API should have resulted in delisting of the offending apps, NOT with the removal of a perfectly functional, stable API without a clear replacement for anything more complex than a basic form.
The v4 modal is completely unusable right now and closing this issue without any further consideration is sad for all the apps that used the Fullscreen API as intended.
mirceapiturca
commented
4 months ago @darrynten Summed it up nicely. We've ended up with a completely unusable almost full screen modal. BTW Shopify apps still use the legacy true fullscreen. Take a look at Translate & Adapt.
chindnguyen
commented
4 months ago The max modal is working so badly, don't know why you guys can release and force us to use it while still having many issues. We can do nothing with our app page builder, the styled-components cannot work, popover, overlay cannot work too. The Title Bar with grouped secondary buttons cannot work, it only shows the secondary button, the button with the variant breadcrumb cannot work too 👎
You guys forced us to use max modal of the new app-bridge instead of the old fullscreen mode, but the app Shopify such as Emails or Translate & Adapt still using the old Fullscreen mode, which is so bad to app partners
The FullScreen API was deprecated in favor of a Modal-based approach. This change presents significant drawbacks for application vendors, as outlined below:
Reduced Interface Space: The FullScreen API was previously leveraged due to its capability to support complex user interfaces that necessitate expanded visual real estate. The transition to Modal constrains this space, negatively impacting user experience and functionality.
Integration Issues with Polaris Components: Components from the Polaris design system, such as Popover and Tooltip, don't work within a Modal context. This compatibility issue undermines the consistency and reliability of user interfaces built using these components.
User Interface Disruptions: The nested nature of modals and other overlays within the Modal framework leads to a cluttered and confusing user interface. This design choice detracts from the overall user experience, making navigation and interaction less intuitive.
Complexities with Embedding iFrames: The Modal implementation introduces complexities when embedding iFrames, given that the modal itself functions as an iFrame. This layering complicates integration and limits the functionality of embedded content within the modal environment.
The FullScreen API offered a straightforward, efficient solution for achieving better user interfaces. Its removal in favor of a less versatile and more problematic Modal approach raises questions about the rationale behind this decision.