search

Shopify / shopify-app-bridge

https://shopify.dev/docs/api/app-bridge
82 stars 9 forks source link

Expose resourcePicker resource types from @shopify/app-bridge-types (to be used in combination with @shopify/app-bridge-react) #370

Open muchisx opened 4 weeks ago

muchisx commented 4 weeks ago

Describe the feature you’d like

Expose necessary types from the file shopify.ts so they can be imported within user's applications and referenced for easier typing components, functions etc..

Or even better, expose them directly from @shopify/app-bridge-react

Describe alternatives you've considered

I have had to to install @shopify/app-bridge which has a dependency on @shopify/app-bridge-core (I could just install the latter I know) just to access to types.

But ideally, those types would just be exposed from the library that's providing the resource, in this case, I would prefer them to be exported from @shopify/app-bridge-react or atleast include @shopify/app-bridge-core as a dependency of @shopify/app-bridge-react so we can reference those types from there

schiller-manuel commented 4 weeks ago

duplicate of https://github.com/Shopify/shopify-app-bridge/issues/370

muchisx commented 4 weeks ago

@schiller-manuel, this is issue #370

schiller-manuel commented 4 weeks ago

sorry for my copy & paste error :D I meant duplicate of https://github.com/Shopify/shopify-app-bridge/issues/354