Shopify / shopify-app-js

MIT License
218 stars 88 forks source link

Proxy from toml not updating on store app. #1122

Open lawrencetaur opened 1 week ago

lawrencetaur commented 1 week ago

Issue summary

Before opening this issue, I have:

I have been trying to send a proxy requests from /apps/proxy to a route on my Shopify Remix app. it worked initially.

I then changed the subpath in shopify.app.toml. This updated the setting in the partners dashboard correctly. However, it did not update correctly on the development store

Expected behavior

It should update the subpath for the app on the store as well. The store may have /apps/proxy but If I change it in the app settings to /apps/proxy1 or /apps/carrier, it does not update on the store.

Actual behavior

The sub path does not update on the store, not sure why it can't fetch the sub path from the app settings but has its own copy of the path.

What actually happens?

Steps to reproduce the problem

  1. create proxy in sopify.app.toml add the following settings [app_proxy] url = "https://domain.com/apps/proxy" subpath = "carrier" prefix = "apps"
  2. test the proxy hitting your endpoint, it should work. storeurl.com/apps/proxy will work well.
  3. now change the proxy url to [app_proxy] url = "https://domain.com/apps/carrier" subpath = "carrier" prefix = "apps" This will update correctly in the partners dashboard under app settings. but when you visit storeurl.com/apps/carrier it will return a 404.
matteodepalo commented 3 days ago

Hi @lawrencetaur, thank you for opening this issue. What happens if you re-install the app on the store, does the URL get updated?