AppProxyForm does not handle ref attribute

[ngbrown]

Issue summary

Before opening this issue, I have:

• [x] Upgraded to the latest version of the relevant packages
  • @shopify/shopify-app-remix package and version: 3.3.2
  • Node version: v20.17.0
  • Operating system: Windows 10
• [ ] Set { logger: { level: LogSeverity.Debug } } in my configuration, when applicable
• [x] Found a reliable way to reproduce the problem that indicates it's a problem with the package
• [x] Looked for similar issues in this repository
• [x] Checked that this isn't an issue with a Shopify API
  • If it is, please create a post in the Shopify community forums or report it to Shopify Partner Support

The documentation says the <AppProxyForm/> component can be used in place of Remix's <Form/> but it does not correctly handle setting the ref attribute.

Expected behavior

What do you think should happen?

Accept the ref attribute and enable calling form functions such as form.current.submit().

Actual behavior

What actually happens?

Type '{ children: Element; ref: RefObject; method: "POST"; onSubmit: (ev: FormEvent) => void; onReset: () => void; }' is not assignable to type 'IntrinsicAttributes & AppProxyFormProps'. Property 'ref' does not exist on type 'IntrinsicAttributes & AppProxyFormProps'.ts(2322)

The component does not use forwardRef as it should.

https://github.com/Shopify/shopify-app-js/blob/08627d858b2fcdbaa8c200e29fb66b8b5928c06a/packages/apps/shopify-app-remix/src/react/components/AppProxyForm/AppProxyForm.tsx#L63-L79

Line 63 should be:

export const AppProxyForm = forwardRef(function AppProxyForm(props: AppProxyFormProps, ref?: LegacyRef<HTMLFormElement>) {

Line 75 should be:

<Form action={context.formatUrl(action, false)} {...otherProps} ref={ref}>

Steps to reproduce the problem

const form = useRef<HTMLFormElement>(null);
return (
  <AppProxyForm ref={form} action="/app/settings">
  </AppProxyForm>
);

Debug logs

N/A

[lizkenyon]

Hi there 👋

Thanks for flagging, and taking a detailed look into the problem. If you would like to feel free to put up a PR for this issue, and the team will prioritize reviewing it. Otherwise I will add this ticket to the backlog of work for us to resolve.

Thanks again!