Open ngbrown opened 2 weeks ago
Hi there 👋
Thanks for flagging, and taking a detailed look into the problem. If you would like to feel free to put up a PR for this issue, and the team will prioritize reviewing it. Otherwise I will add this ticket to the backlog of work for us to resolve.
Thanks again!
Issue summary
Before opening this issue, I have:
@shopify/shopify-app-remix
package and version: 3.3.2{ logger: { level: LogSeverity.Debug } }
in my configuration, when applicableThe documentation says the
<AppProxyForm/>
component can be used in place of Remix's<Form/>
but it does not correctly handle setting theref
attribute.Expected behavior
What do you think should happen?
Accept the
ref
attribute and enable calling form functions such asform.current.submit()
.Actual behavior
What actually happens?
The component does not use
forwardRef
as it should.https://github.com/Shopify/shopify-app-js/blob/08627d858b2fcdbaa8c200e29fb66b8b5928c06a/packages/apps/shopify-app-remix/src/react/components/AppProxyForm/AppProxyForm.tsx#L63-L79
Line 63 should be:
Line 75 should be:
Steps to reproduce the problem
Debug logs
N/A