search

Shopify / shopify-app-js

MIT License
294 stars 116 forks source link

Help understanding release cycle for package #1755

Closed KevinGrandon closed 1 week ago

KevinGrandon commented 1 week ago

Hello,

I submitted and got this PR landed on Oct 7th: https://github.com/Shopify/shopify-app-js/pull/1597

On Oct 29th, this was released: https://github.com/Shopify/shopify-app-js/releases/tag/%40shopify%2Fshopify-app-remix%403.4.0

I don't see my changes listed in the release, or having been published to NPM. Just wondering if I'm missing something in the pull request, or if there's some way to get that released. Thanks!

lizkenyon commented 1 week ago

Hi there @KevinGrandon

Before releasing during our testing we discovered your PR did not resolved the issue. So unfortunately we had to revert the PR.

It appears as though the rollup plugin does not properly handle dependencies.

We would review another PR if you are able to get this working. :)

KevinGrandon commented 1 week ago

Understood, thank you for the reply! If I get time in the next few days I'll try to pick this up again.