Shopify / shopify-app-js

MIT License
297 stars 117 forks source link

Installation process fails in iOS webview with token exchange strategy for `shopify-app-remix` #714

Open zakariamofaddel opened 8 months ago

zakariamofaddel commented 8 months ago

Issue summary

Before opening this issue, I have:

Expected behavior

The installation flow completes successfully on iOS Shopify app webview.

Actual behavior

During the installation process the auth.$ remix route is called and in turn it calls await authenticate.admin(request);, the flow reaches then the respondToBouncePageRequest and it throws a Response containing the script that should load AppBridge from https://cdn.shopify.com/shopifycloud/app-bridge.js. This is where the flow gets interrupted and I am not able to debug any further.

Steps to reproduce the problem

  1. Create a Shopify app using the remix template
  2. Install on development store from Desktop computer and then uninstall the app.
  3. Now using an iOS device go to the Shopify mobile app -> Settings -> Apps and Sales channels -> Uninstalled and install the app.
pobed2 commented 7 months ago

Thank you for reporting this! We were able to reproduce on our side and we'll look at fixing this in the near future.

github-actions[bot] commented 5 months ago

We're labeling this issue as stale because there hasn't been any activity on it for 60 days. While the issue will stay open and we hope to resolve it, this helps us prioritize community requests.

You can add a comment to remove the label if it's still relevant, and we can re-evaluate it.

zzooeeyy commented 4 months ago

Mobile vs desktop uninstall behaviour

https://github.com/Shopify/shopify-app-js/assets/102243935/52356d4c-2151-4fc2-a58b-41c9193e2818

https://github.com/Shopify/shopify-app-js/assets/102243935/428f6ea9-d1cf-4418-8c48-1313897a6b4b

github-actions[bot] commented 2 months ago

We're labeling this issue as stale because there hasn't been any activity on it for 60 days. While the issue will stay open and we hope to resolve it, this helps us prioritize community requests.

You can add a comment to remove the label if it's still relevant, and we can re-evaluate it.