search

Shopify / shopify-app-js

MIT License
225 stars 90 forks source link

Enhancement Query: Nullable Fields in gift_card Type #769

Open sbmsr opened 8 months ago

sbmsr commented 8 months ago

Overview/summary

First and foremost, I would like to express my gratitude for the work you’ve done with this library; it’s been invaluable to our projects.

I'm reaching out to inquire about the design decisions regarding the gift_card type, specifically concerning the nullable fields as seen here: gift_card.ts#L178.

We've noticed that the need to check for null values in these fields frequently adds complexity to our codebase. Could you please provide some insight into the reasoning behind making these fields nullable? Understanding the rationale might help us better handle these cases or contribute to a potential enhancement if appropriate. Ty!

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

github-actions[bot] commented 4 months ago

We're labeling this issue as stale because there hasn't been any activity on it for 60 days. While the issue will stay open and we hope to resolve it, this helps us prioritize community requests.

You can add a comment to remove the label if it's still relevant, and we can re-evaluate it.

github-actions[bot] commented 1 month ago

We're labeling this issue as stale because there hasn't been any activity on it for 60 days. While the issue will stay open and we hope to resolve it, this helps us prioritize community requests.

You can add a comment to remove the label if it's still relevant, and we can re-evaluate it.