search

Shopify / shopify-app-js

MIT License
290 stars 116 forks source link

Please show affected resource in GQL deprecation error #775

Closed Michael-Gibbons closed 4 months ago

Michael-Gibbons commented 1 year ago

Overview/summary

Many times during development I may get deprecation notices like the one below. I'm not sure if the message is just informing me of a deprecation in the abstract or if something in my code is on the chopping block for deprecation.

In Apps > YOUR_APP > API Health the shopify admin gives me a list of exactly which properties are to be deprecated, but this is not useful for custom apps or during development.

Please include some way of getting the GQL properties which need to be updated to be compliant with the latest version of the GQL API

image

jmunozz commented 1 year ago

Hi. Btw I got the same exact error and my webhooks won't sync anymore using

shopify.api.webhooks.register({ session})

Have you found what goes wrong ? Tks !

weeksie commented 1 year ago

Amazing that this has been open since May. What a hostile thing to do to client developers. I just spent an hour chasing this down only

  1. find out about that the "insights" section in the Partners dashboard shows deprecated calls. Might be worth checking this if you're getting these errors.
  2. In my case I found that there have been no deprecated calls made by my app, despite these useless/scary warnings

It's tough to have sympathy for things like this when the sole job of an API library is to ease integrations. Why throw a useless message? Why waste what must be 1000s of developer hours for no reason? And why hasn't anybody addressed this thread?

Realizing this is probably a server side issue, since it looks like the code just pipes the warning from the server. Maybe someone, anyone who is supposed to watch this repo could file a ticket with your API team.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

Michael-Gibbons commented 1 year ago

Bumping this

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

Michael-Gibbons commented 1 year ago

Bumping this.

github-actions[bot] commented 10 months ago

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

Michael-Gibbons commented 10 months ago

"If I bump this one more time I'm sure they'll notice it" image

Michael-Gibbons commented 8 months ago

image image

The shopify cli seems to think this query has some deprecated properties, the 2024-01 docs seem to disagree. If the deprecated property was passed into the logdata from the shopify cli that would be super neat so I didn't have to be gaslit by warnings.

lizkenyon commented 6 months ago

Hi folks :wave: First of all we are so sorry that we missed this ticket. It had been removed from our tracking and we were missing all of these updates. We will do better in the future.

As some of you have suspected these warnings in the library are warnings returned by the API in the deprecation header. And then the library logs them. I think you are bringing up very valid concerns about the quality of these error messages, and how better quality error messages would help you to solve these problems more quickly.

I am passing on this feedback to the product team.

If you are working on a public app I would also recommend using the insights found in the partner dashboard as they may provide more detail.

Thanks again for your patience.

Michael-Gibbons commented 6 months ago

WOO DREAMS REALLY DO COME TRUE

Thank you @lizkenyon

My dreams are alive, my heart is aflutter with the possibilities, and I am floating on clouds made of cream.

github-actions[bot] commented 4 months ago

We're labeling this issue as stale because there hasn't been any activity on it for 60 days. While the issue will stay open and we hope to resolve it, this helps us prioritize community requests.

You can add a comment to remove the label if it's still relevant, and we can re-evaluate it.

Michael-Gibbons commented 4 months ago

image Bump

lizkenyon commented 4 months ago

Hey @Michael-Gibbons

I appreciate a good meme as much as the next person, and I will bump this with the product team again, but at this time I will be closing this ticket, as it is not a fix that we can be doing at the library level.