search

Shopify / shopify-app-template-node

MIT License
867 stars 391 forks source link

App is outdated with new admin routes #1223

Closed Michael-Gibbons closed 1 year ago

Michael-Gibbons commented 1 year ago

Issue summary

The new admin routes are making an outdated app warning appear on development apps. This is either a bug in this template failing to cover certain security criteria or a bug in the shopify admin itself.

Expected behavior

This error should not occur since:

Here is the documentation for that

Actual behavior

The error occurs, for some reason it only happens on dev, when in production the error does not occur.

I've tested this on:

image

Steps to reproduce the problem

  1. Install the app
  2. run dev
arsamFarooq commented 1 year ago

Facing same error on shopify version "@shopify/cli": "3.28.0"

mkevinosullivan commented 1 year ago

@Michael-Gibbons Where does this error screen occur? During the install flow? If so, before or after the permission grant screen?

arsamFarooq commented 1 year ago

@mkevinosullivan I faced this error after installation and each time the app is loaded.

mkevinosullivan commented 1 year ago

@arsamFarooq @Michael-Gibbons Is this still happening? I saw it briefly a while ago but can no longer reproduce it. I'm wondering if it was a temporary issue observed during the rollout of the Unified Admin to all the stores.

Michael-Gibbons commented 1 year ago

@mkevinosullivan I am also no longer seeing it. Feel free to close if you believe the issue is resolved. Thanks!