search

Shopify / shopify-app-template-node

MIT License
892 stars 402 forks source link

Update redirectUrl returned by `getEmbeddedAppUrl` utility #1242

Closed rennyG closed 1 year ago

rennyG commented 1 year ago

WHY are these changes introduced?

Fixes https://github.com/Shopify/shopify-dev/issues/31542

Partner feedback reported incorrect redirect URL. Confirmed change with @byrichardpowell

WHAT is this pull request doing?

Updates method in auth.js for redirecting to the URL returned by the getEmbeddedAppUrl utility

Note to reviewers

Note to reviewers, not sure how to add/update the test for this change

Checklist

Note: once this PR is merged, it becomes a new release for this template.

paulomarg commented 1 year ago

I don't think this file exists any more, it was removed when we introduced the Express package.

rennyG commented 1 year ago

I updated outdated content. Closing this PR.