Shopify / shopify-app-template-node

MIT License
867 stars 391 forks source link

[WIP] Add `react-i18next` to Node app template #1247

Closed trishrempel closed 1 year ago

trishrempel commented 1 year ago

WHY are these changes introduced?

Part of the project App Localization - Tools and Guidance (tech design).

Translating apps is technically challenging, time-consuming, and costly. Despite the high demand for localized apps internationally, only a small fraction of apps offered in the Shopify App Store are translated.

None of Shopify's app templates are localized, meaning that the full burden of responsibility is on the developer to research and implement an i18n framework for their app. It’s also more likely to be an afterthought until the developer decides to expand internationally, at which point the effort to externalize all the app's strings is much higher.

By localizing the default Node app template, we reduce the toil for developers, and give them a head start in localizing their apps from the start.

WHAT is this pull request doing?

This is a draft pull request for the purposes of discussion - it will not be merged until:

  1. It has buy-in with the client libraries & app templates team
  2. It has been updated to use the Storefront locale file format used by themes and app UI extensions
  3. The README has been updated

This PR:

Why react-i18next?

To Do

Checklist

Note: once this PR is merged, it becomes a new release for this template.

trishrempel commented 1 year ago

Wrong repo 🤦🏻 , closing