added calendar view and might have fixed the cli issue.

Shopify / shopify-app-template-node

MIT License

860 stars 393 forks source link

added calendar view and might have fixed the cli issue. #1281

Closed ShyGuy76 closed 5 months ago

ShyGuy76 commented 1 year ago

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

Checklist

Note: once this PR is merged, it becomes a new release for this template.

[ ] I have added/updated tests for this change
[ ] I have made changes to the README.md file and other related documentation, if applicable

sle-c commented 5 months ago

Hi @ShyGuy76,

Thank you for your contribution. This PR added a react-calendar dependency to the template which will apply to everyone using this template. While react-calendar is a good library, I don't think that everyone needs it. It's best to use the Shopify CLI to create a new Shopify app (documentation). It'll use this template and you can add react-calendar there as a dependency for your app.

Therefore, I'll close this PR as it's not applicable.