Shopify / shopify-app-template-node

MIT License
890 stars 402 forks source link

update shopify app express and sql lite session storage #1343

Closed andy-liuu closed 4 weeks ago

andy-liuu commented 4 weeks ago

WHY are these changes introduced?

After this release of many js npm packages, we should update the dependencies to their latest versions.

WHAT is this pull request doing?

Test this PR

shopify app init --template=https://github.com/Shopify/shopify-app-template-node#andy-liuu/update-dependencies

Checklist

Note: once this PR is merged, it becomes a new release for this template.

fullstackdeveloper918 commented 2 weeks ago

After this change. I am unable to generate access token in sqlite for custom server. it was working fine before this change.

andy-liuu commented 2 weeks ago

@fullstackdeveloper918

Thank you for flagging this! Could you please create an issue with reproduction steps? This will help us investigate and resolve the bug more effectively.

fullstackdeveloper918 commented 2 weeks ago

Earlier I was using this template to build our all shopify public apps. I am using vultr.com server to host the app. From last week whenever I am trying to install app using custom redirect urls, access token is not getting stored in SQLITE. without access token app is not working. We have no option to stop using node template now.

lizkenyon commented 2 weeks ago

Hey @fullstackdeveloper918!

Sorry to hear you have run into this issue. We would love to try to investigate it further!

If you could create an issue with example code that would allow us to reproduce the issue, that would allow us to investigate further! Our initial test on a fresh app template did not reproduce the issue.

fullstackdeveloper918 commented 2 weeks ago

There is no need to send any code, video. I am not using my app which I built with yiur app just to make sure wther it is my code issue or template's issue. I am using exact same sample app'code,It is very first step. this issue comes with installation. First we start with normal commands you mentioned in readme file. When we go with normal cloudflare urls which app generate automatically, it gets installed on one store and stores access token in sqlite. 2nd time, I have to change my redirect urls, application urls so I can recieve access token on my server. After updating my server urls it never store any access token in sqlite DB. I am not doing any mistake in settings. I have same access scopes, valid working redirect urls, valid apiKEY and Secret. You can easily replicate issue by trying app on custom linux server with ubuntu 22.04 version and nginx server.

lizkenyon commented 2 weeks ago

2nd time, I have to change my redirect urls, application urls

To clarify are you saying that when you are in local development using a cloudflare tunnel the installation works correctly. But when you are running your application in production, and update to the production application URLs that is when the app is not installing correctly?

updating my server urls it never store any access token in sqlite DB.

If you turn on debug logging are you seeing any errors in the terminal? Are you seeing any errors in the UI during install? Does your app show as installed in the list of installed apps in the Shopify Admin?

fullstackdeveloper918 commented 2 weeks ago

It gets installed successfully. When I try to open the app inside the admin panel, it gives an issue called exit frame outside from shopify. This issue generally comes when we miss the access token. I have checked the SqlLite and the token was not there. Let me check the debug log as well.

Thanks

@.***>

Pankaj Sharma Director, CyberSify Cloud Computing Pvt. LTD.

950 <9501151756>1 <9501151756>151756 <9501151756> | @.***

https://cybersify.tech D 264-265B Phase, 2nd Floor, Phase 8B, Industrial Area, Sector 74, Sahibzada Ajit Singh Nagar, Punjab 160071

On Wed, 13 Nov 2024 at 01:08, Liz Kenyon @.***> wrote:

2nd time, I have to change my redirect urls, application urls

To clarify are you saying that when you are in local development using a cloudflare tunnel the installation works correctly. But when you are running your application in production, and update to the production application URLs that is when the app is not installing correctly?

updating my server urls it never store any access token in sqlite DB.

If you turn on debug logging are you seeing any errors in the terminal? Are you seeing any errors in the UI during install? Does your app show as installed in the list of installed apps in the Shopify Admin?

— Reply to this email directly, view it on GitHub https://github.com/Shopify/shopify-app-template-node/pull/1343#issuecomment-2471409138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJYMG35M6D75QU6VVWLGBL2AJKLHAVCNFSM6AAAAABQ2DI6H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZRGQYDSMJTHA . You are receiving this because you were mentioned.Message ID: @.***>