Shopify / shopify-app-template-remix

364 stars 149 forks source link

Remix Link doesn't render inside <NavMenu> #845

Closed dizzyjaguar closed 1 month ago

dizzyjaguar commented 2 months ago

Included with this template is the use of the app bridge <NavMenu>, which is supposed to render links inside of a menu underneath the app name on the side. This actually does not work with remix's <Link>, so either the template should include

Hujjat commented 1 month ago

Hey @dizzyjaguar

<Link> is not a Polaris component in this Remix template. You should import it from @remix-run/react

import { Link } from "@remix-run/react";

If you did this and still not working, the error is probably somewhere else in your code that's causing issue and prevent links to render.

dizzyjaguar commented 1 month ago

@Hujjat right, it was importing from remix-run/react but would not render in the <NavMenu> on app/routes/app.tsx. Maybe its fixed now but doesn't work in mine, thus I need to use another Link for it to render inside <NavMenu>.

matteodepalo commented 1 month ago

@dizzyjaguar thank you for opening this issue. Could we have more context around where you're seeing the problem? More code would help understand if you have something in your setup creating issues.

github-actions[bot] commented 1 month ago

We are closing this issue because we did not hear back regarding additional details we needed to resolve this issue. If the issue persists and you are able to provide the missing clarification we need, you can respond here or create a new issue.

We appreciate your understanding as we try to manage our number of open issues.