Closed iphipps closed 1 month ago
The afterAuth hook runs once on install. If a developer uninstalls and reinstalls, the afterAuth hook does not run because there is still a valid session. We need to properly await the deleting of sessions.
shopify app init --template=https://github.com/Shopify/shopify-app-template-remix#iphipps\/invalidate-session-on-uninstall
app/shopify.server.ts
Compare the behavior to main notice how afterAuth is run once.
main
README.md
CHANGELOG.md
WHY are these changes introduced?
The afterAuth hook runs once on install. If a developer uninstalls and reinstalls, the afterAuth hook does not run because there is still a valid session. We need to properly await the deleting of sessions.
WHAT is this pull request doing?
Test this PR
app/shopify.server.ts
to see when it runs.Compare the behavior to
main
notice how afterAuth is run once.Checklist
README.md
file and other related documentation, if applicableCHANGELOG.md