search

Shopify / shopify-app-template-remix

371 stars 149 forks source link

Remove the mandatory compliance webhook topics. These are only neede… #867

Closed byrichardpowell closed 1 month ago

byrichardpowell commented 1 month ago

WHY are these changes introduced?

Mandatory compliance topics are only needed for public apps. This template is used for both public and private apps. So including the mandatory compliance webhooks is noise for non private apps. We prefer to have a leaner temlate which developers can add to, rather than a fullr template which may require deleting some code.

WHAT is this pull request doing?

  1. Remove the webhook handlers for mandatory compliance webhooks (for public apps).
  2. Comment out the webhook config for these topics in shopify.app.toml.
  3. Move the app uninstalled config to the top
  4. Move the commented out product filters webhook to the top since it's more likely to be universally usefull than compliance topics.

Test this PR

shopify app init --template=https://github.com/Shopify/shopify-app-template-remix#fewer-webhooks

I haven't tested this PR yet. First I want to be sure this is what we want.

Checklist

byrichardpowell commented 1 month ago

Once I know these are the changes we want, I can test the DX for these changes.