Shopify / shopify-cli

Shopify CLI helps you build against the Shopify platform faster.
https://shopify.dev/tools/cli
Other
1.01k stars 202 forks source link

Cannot pull theme. Dozens of errors with image assets. #1360

Closed trev-dev closed 3 years ago

trev-dev commented 3 years ago

Write a short description of the issue here ↓

I'm making multiple attempts to pull an existing theme from shopify and shopify-cli shopify theme pull -i 12463859322 keeps throwing errors

Shopify Cli Version 2.0.2 installed via Ruby Gems 3.2.21

➜  general git:(master) ✗ shopify theme pull -i 1234567891011
┏━━ Pulling theme files from Swatch Debug Jul 8 (#1234567891011) on store.myshopify.com ━━━━━━━━━━━
┃                                                                                                         100%
┃ ERROR get assets/adobe-w-undyed.png: wrong number of arguments (given 4, expected 2..3)
┃ // About 50 more lines of this error for various image assets for the theme.
┃ ERROR get assets/white.png: wrong number of arguments (given 4, expected 2..3)
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ (72.51s) ━━
✓ Theme pulled successfully (Nope!)
adrianocr commented 3 years ago

I'm also having similar errors:

┃ ERROR get assets/0.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/6.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/favicon.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/Clean.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/flex-icon.ttf: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/flex-icon.woff: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/Keto.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/Gluten-Free.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/minus.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/minus1.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/Non-GMO.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/Paleo.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/password-page-background.jpg: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/plus.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/slick-theme.less: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/ssw-fontello.woff: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/testimonial-icon.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/Vegan.png: wrong number of arguments (given 4, expected 2..3)
nitannn commented 3 years ago

Getting the same error as well 👆🏽

dgtlmonk commented 3 years ago

+1

dgtlmonk commented 3 years ago

It seems like this error doesn't appear if your theme is Online Store 2.0 compatible (dawn)

DistantMemory commented 3 years ago

+1

┃ ERROR get assets/black-grey.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/black-transparent.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/black-tortoise.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/black-white.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/black.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/brown-tortoise.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/blue-tortoise.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/envelope.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/gold-brown.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/geolizr-currency-flags.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/gold-light-pink.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/green-grey.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/grey-silver.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/icon-account.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/icon-email.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/icon-cart.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/icon-instagram.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/icon-facebook.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/leaf.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/navy.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/red.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/tortoise.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/password-page-background.jpg: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/transparent-silver.png: wrong number of arguments (given 4, expected 2..3)

earthtooliver commented 3 years ago

+1 here, struggling to get my site's swatch/radio buttons to link to the images even after adding and pushing the missing assets to the theme. on the latest version of cli as well.

lesterdefreitas commented 3 years ago

+1

dspeake commented 3 years ago

+1

┃ ERROR get assets/password.jpg: wrong number of arguments (given 4, expected 2..3)

EmbarkJosh commented 3 years ago

+1

Shopify CLI Version: 2.1.0 Ruby: ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x64-mingw32] RubyGems: 3.2.23 VS Code: 1.58.2 (user setup) OS: Windows_NT x64 10.0.19043

┃ ERROR get assets/algolia_dependency_fontawesome-webfont.eot: wrong number of arguments (given 4, expected 2..3)       
┃ ERROR get assets/algolia_dependency_fontawesome-webfont-ie-fix.eot: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/algolia_dependency_fontawesome-webfont.ttf: wrong number of arguments (given 4, expected 2..3)       
┃ ERROR get assets/algolia_dependency_fontawesome-webfont.woff: wrong number of arguments (given 4, expected 2..3)      
┃ ERROR get assets/big_noodle_titling.woff: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/algolia_dependency_fontawesome-webfont.woff2: wrong number of arguments (given 4, expected 2..3)     
┃ ERROR get assets/black.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/dark-brown.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/favicon.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/flex-icon.ttf: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/flex-icon.woff: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/password-page-background.jpg: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/Rubik-Bold.ttf: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/Rubik-Italic.ttf: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/Rubik.ttf: wrong number of arguments (given 4, expected 2..3)
martinstonis commented 3 years ago

+1

andrclp commented 3 years ago

+1

┃ ERROR get assets/favicon.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/blank.gif: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/loader.gif: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/loader2x.gif: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/select.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/password-page-background.jpg: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/select_light.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/soldout.png: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/turbo.eot: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/turbo.ttf: wrong number of arguments (given 4, expected 2..3) ┃ ERROR get assets/turbo.woff: wrong number of arguments (given 4, expected 2..3)

monaounagi commented 3 years ago

+1

┃ ERROR get assets/password.jpg: wrong number of arguments (given 4, expected 2..3)
lesterdefreitas commented 3 years ago

It seems like this error doesn't appear if your theme is Online Store 2.0 compatible (dawn)

Oh that's interesting, thanks for the observation @dgtlmonk. I hope that doesn't mean that Shopify will give this a low priority though. Working with non Online Store 2.0 themes is still going to be a part of the workflow for developers for a long time. Heck we even have some clients with themes so old they don't even use sections at all!

It would be frustrating to have to switch between themekit and cli for these different scenarios.

dspeake commented 3 years ago

It appears to be related to the files themselves. For the store I have an issue with, I just uploaded Dawn and pulled the theme successfully. When I uploaded password.jpg to that same theme though, the error returns for that file.

This is the image.

fabiancpl commented 3 years ago

Hi. Is there a way to deal with this problem?

lesterdefreitas commented 3 years ago

@fabiancpl This solution does seem to work for now. It's not ideal of course but it seems to be the only way for now to deal with this problem when it arises.

aodreman commented 3 years ago

I am getting the same error with password.jpg, which is a file that comes with the theme, this is happening with the initial pull.

DavidWaters-AP commented 3 years ago

I found another workaround.. but still testing it. Like many above, I could not do a pull request without a boatload of asset parameter issues.. I tried the various 'solutions' linked above but none resolved the problem.. So to get this working correctly I download the theme direct from Shopify using the theme export function and then unzipped the theme to my development folder and did a CLI push of the downloaded theme back up to Shopify. I can now do pull requests without the asset issues. However, if you add an app you may need to re-export the Shopify theme and do the process again to get this to work again and again.

austinhutchison commented 3 years ago

I have this issue as well for images and fonts in the assets folder

When trying the solution in 1361 it stalled on 99% on the first attempt, and then on the second attempt gave the same error.

adrianocr commented 3 years ago

There are a lot of hacks being posted here but ideally Shopify should just fix this. It doesn't seem to me like there is a good reason for it failing to pull the items in the /assets/ dir.

In any case the easiest "hack" for this is to revert to themekit for the assets only.

cd [project-name] && rm -rf ./assets && theme download /assets/ --env=[YOUR RELEVANT ENV HERE]

Problem solved, themekit will download all the assets that shopify-cli failed to download and then you can revert to using shopify-cli from there on.

jgiordanoGG commented 3 years ago

+1

┃ ERROR get assets/bc-sf-filter-ico.eot: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/bc-sf-filter-ico.ttf: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/bc-sf-filter-ico.woff: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/bcs_store_logo.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/cbox_border1.png: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/cbox_border2.png: wrong number of arguments (given 4, expected 2..3)

spencer1573 commented 3 years ago

+1

  1. i pushed what i had to shopify
  2. then another person put in some assets and changes
  3. then i had these type of errors when i tried to pull their changes

┃ ERROR get assets/picture.jpeg: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/picture-2.png: wrong number of arguments (given 4, expected 2..3)

jgiordanoGG commented 3 years ago

FWIW, I just upgraded shopify-cli from 2.2.2 to 2.3.0 and no longer see the previous errors I encountered. I can't say for sure this is what fixed it, though I hadn't done anything else so it seems to be the reason. YMMV, but it seems worth checking your version if you continue to see this issue.

lesterdefreitas commented 3 years ago

FWIW, I just upgraded shopify-cli from 2.2.2 to 2.3.0 and no longer see the previous errors I encountered. I can't say for sure this is what fixed it, though I hadn't done anything else so it seems to be the reason. YMMV, but it seems worth checking your version if you continue to see this issue.

@jgiordanoGG Oh that's awesome. My problem though is that I'm currently stuck on MacOS 10.13 and it doesn't look like I can update the cli to that version becuase it keeps throwing an error when trying to update one of the dependencies, openssl. By any chance does anyone have a solution for me on that one besides the obvious (getting a new computer)? 😅

austinhutchison commented 3 years ago

Updating to 2.3.0 worked for me!

@lesterdefreitas I can't say for sure but you could try updating 2.2.2 with the changes made in the PR here: https://github.com/Shopify/shopify-cli/pull/1319

lesterdefreitas commented 3 years ago

@austinhutchison Hmm, could be worth a try. Would you happen to know the default installation location for shopify-cli on mac? I installed via Homebrew.

catboxer commented 3 years ago

Just pulled a client theme with shopify cli 2.1 ERROR get assets/icons.eot: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/icons.ttf: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/icons.woff: wrong number of arguments (given 4, expected 2..3)
┃ ERROR get assets/password-page-background.jpg: wrong number of arguments (given 4, expected 2..3)

updated to 2.4 and error gone.

trev-dev commented 3 years ago

I spent some time with shopify-cli 2.4 myself here and was also able to work without this issue. It's good to keep your gems up-to-date :)

Closing this for now.