search

Shopify / shopify-cli

Shopify CLI helps you build against the Shopify platform faster.
https://shopify.dev/tools/cli
Other
1.01k stars 202 forks source link

Flaky test ShopifyCLI::Theme::SyncerTest#test_upload_theme_with_delayed_low_priority_files #1710

Closed cecyc closed 2 years ago

cecyc commented 3 years ago

Issue summary

The following test is flaky

Failure:
ShopifyCLI::Theme::SyncerTest#test_upload_theme_with_delayed_low_priority_files [/home/runner/work/shopify-cli/shopify-cli/test/shopify-cli/theme/syncer_test.rb:314]
Minitest::Assertion: Expected #<ShopifyCLI::Theme::Syncer:0x00005649f266f750 @ctx=#<TestHelpers::FakeContext:0x00005649f264c2c8 @root="/home/runner/work/shopify-cli/shopify-cli/test/fixtures/theme", @env={"DOTNET_NOLOGO"=>"1", "DEPLOYMENT_BASEPATH"=>"/opt/runner", "USER"=>"runner", "BUNDLER_VERSION"=>"2.2.29", "CI"=>"true", "PIPX_HOME"=>"/opt/pipx", "GITHUB_ENV"=>"/home/runner/work/_temp/_runner_file_commands/set_env_f4590c6e-95ab-4cba-933e-2a358efbf36d", "JAVA_HOME_8_X64"=>"/usr/lib/jvm/adoptopenjdk-8-hotspot-amd64", "SHLVL"=>"1", "RUBYOPT"=>"-r/opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/bundler-2.2.29/lib/bundler/setup", "HOME"=>"/home/runner", "RUNNER_TEMP"=>"/home/runner/work/_temp", "GITHUB_EVENT_PATH"=>"/home/runner/work/_temp/_github_workflow/event.json", "BUNDLER_ORIG_BUNDLER_VERSION"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "JAVA_HOME_11_X64"=>"/usr/lib/jvm/adoptopenjdk-11-hotspot-amd64", "GITHUB_REPOSITORY_OWNER"=>"Shopify", "PIPX_BIN_DIR"=>"/opt/pipx_bin", "JAVA_HOME_12_X64"=>"/usr/lib/jvm/adoptopenjdk-12-hotspot-amd64", "GRADLE_HOME"=>"/usr/share/gradle-7.2", "GITHUB_RETENTION_DAYS"=>"90", "HOMEBREW_PREFIX"=>"/home/linuxbrew/.linuxbrew", "AZURE_EXTENSION_DIR"=>"/opt/az/azcliextensions", "POWERSHELL_DISTRIBUTION_CHANNEL"=>"GitHub-Actions-ubuntu18", "GITHUB_HEAD_REF"=>"", "HOMEBREW_SHELLENV_PREFIX"=>"/home/linuxbrew/.linuxbrew", "GITHUB_GRAPHQL_URL"=>"https://api.github.com/graphql", "NVM_DIR"=>"/home/runner/.nvm", "ImageVersion"=>"20211101.1", "DOTNET_SKIP_FIRST_TIME_EXPERIENCE"=>"1", "SHELLPID"=>"2301", "GITHUB_API_URL"=>"https://api.github.com", "SWIFT_PATH"=>"/usr/share/swift/usr/bin", "GOROOT_1_13_X64"=>"/opt/hostedtoolcache/go/1.13.15/x64", "RUNNER_OS"=>"Linux", "JOURNAL_STREAM"=>"9:21413", "GOROOT_1_14_X64"=>"/opt/hostedtoolcache/go/1.14.15/x64", "CHROMEWEBDRIVER"=>"/usr/local/share/chrome_driver", "RUNNER_USER"=>"runner", "GITHUB_WORKFLOW"=>"Shopify", "_"=>"/opt/hostedtoolcache/Ruby/2.6.6/x64/bin/bundle", "RUBYLIB"=>"/opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/bundler-2.2.29/lib", "GOROOT_1_15_X64"=>"/opt/hostedtoolcache/go/1.15.15/x64", "GITHUB_RUN_ID"=>"1417714922", "GOROOT_1_16_X64"=>"/opt/hostedtoolcache/go/1.16.9/x64", "ImageOS"=>"ubuntu18", "GITHUB_REF_TYPE"=>"branch", "GOROOT_1_17_X64"=>"/opt/hostedtoolcache/go/1.17.2/x64", "GITHUB_BASE_REF"=>"", "BOOTSTRAP_HASKELL_NONINTERACTIVE"=>"1", "GITHUB_ACTION_REPOSITORY"=>"", "PERFLOG_LOCATION_SETTING"=>"RUNNER_PERFLOG", "USER_PWD"=>"/home/runner/work/shopify-cli/shopify-cli", "PATH"=>"/home/runner/work/shopify-cli/shopify-cli/vendor/bundle/ruby/2.6.0/bin:/opt/hostedtoolcache/Ruby/2.6.6/x64/bin:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/home/runner/.local/bin:/opt/pipx_bin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games", "INVOCATION_ID"=>"a4124360837e413c8ffd0e02f9b26512", "RUNNER_TOOL_CACHE"=>"/opt/hostedtoolcache", "RUNNER_TRACKING_ID"=>"github_ae020f69-a0d2-4b91-acc0-d5a131f165d9", "DOTNET_MULTILEVEL_LOOKUP"=>"0", "ANT_HOME"=>"/usr/share/ant", "HOMEBREW_CELLAR"=>"/home/linuxbrew/.linuxbrew/Cellar", "AGENT_TOOLSDIRECTORY"=>"/opt/hostedtoolcache", "GITHUB_ACTION"=>"__run_3", "RUNNER_ARCH"=>"X64", "GITHUB_RUN_NUMBER"=>"550", "BUNDLER_ORIG_MANPATH"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "BUNDLE_BIN_PATH"=>"/opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/bundler-2.2.29/exe/bundle", "LANG"=>"C.UTF-8", "VCPKG_INSTALLATION_ROOT"=>"/usr/local/share/vcpkg", "XDG_CONFIG_HOME"=>"/home/runner/.config", "GITHUB_REF_NAME"=>"main", "CONDA"=>"/usr/share/miniconda", "RUNNER_NAME"=>"GitHub Actions 13", "GITHUB_REPOSITORY"=>"Shopify/shopify-cli", "GITHUB_ACTION_REF"=>"", "ANDROID_NDK_ROOT"=>"/usr/local/lib/android/sdk/ndk-bundle", "DEBIAN_FRONTEND"=>"noninteractive", "SHOPIFY_CLI_TEST"=>"1", "STATS_KEEPALIVE"=>"true", "GITHUB_ACTIONS"=>"true", "BUNDLER_ORIG_BUNDLE_BIN_PATH"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "BUNDLER_ORIG_RUBYOPT"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "GITHUB_REF_PROTECTED"=>"true", "GITHUB_JOB"=>"test", "RUNNER_PERFLOG"=>"/home/runner/perflog", "GITHUB_WORKSPACE"=>"/home/runner/work/shopify-cli/shopify-cli", "ACCEPT_EULA"=>"Y", "GEM_HOME"=>"/home/runner/work/shopify-cli/shopify-cli/vendor/bundle/ruby/2.6.0", "GITHUB_RUN_ATTEMPT"=>"1", "GITHUB_SHA"=>"40b79f40f411f3ee144694f8b3306cd7ae1fc4c0", "BUNDLER_ORIG_RB_USER_INSTALL"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "ANDROID_SDK_ROOT"=>"/usr/local/lib/android/sdk", "GITHUB_ACTOR"=>"cecyc", "GITHUB_REF"=>"refs/heads/main", "BUNDLE_GEMFILE"=>"/home/runner/work/shopify-cli/shopify-cli/Gemfile", "LEIN_HOME"=>"/usr/local/lib/lein", "BUNDLER_ORIG_GEM_HOME"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "JAVA_HOME"=>"/usr/lib/jvm/adoptopenjdk-8-hotspot-amd64", "PWD"=>"/home/runner/work/shopify-cli/shopify-cli", "RUNNER_WORKSPACE"=>"/home/runner/work/shopify-cli", "GITHUB_PATH"=>"/home/runner/work/_temp/_runner_file_commands/add_path_f4590c6e-95ab-4cba-933e-2a358efbf36d", "GEM_PATH"=>"", "HOMEBREW_NO_AUTO_UPDATE"=>"1", "ANDROID_HOME"=>"/usr/local/lib/android/sdk", "GITHUB_SERVER_URL"=>"https://github.com", "GECKOWEBDRIVER"=>"/usr/local/share/gecko_driver", "HOMEBREW_CLEANUP_PERIODIC_FULL_DAYS"=>"3650", "GITHUB_EVENT_NAME"=>"push", "LEIN_JAR"=>"/usr/local/lib/lein/self-installs/leiningen-2.9.7-standalone.jar", "HOMEBREW_REPOSITORY"=>"/home/linuxbrew/.linuxbrew/Homebrew", "CHROME_BIN"=>"/usr/bin/google-chrome", "BUNDLER_ORIG_BUNDLE_GEMFILE"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "BUNDLER_ORIG_GEM_PATH"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "BUNDLER_ORIG_PATH"=>"/opt/hostedtoolcache/Ruby/2.6.6/x64/bin:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/home/runner/.local/bin:/opt/pipx_bin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin", "SELENIUM_JAR_PATH"=>"/usr/share/java/selenium-server-standalone.jar", "ANDROID_NDK_HOME"=>"/usr/local/lib/android/sdk/ndk-bundle", "BUNDLER_ORIG_RUBYLIB"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "CLI_FRAME_STACK"=>"", "CLI_STYLE_STACK"=>""}>, @theme=#<ShopifyCLI::Theme::Theme:0x00005649f266f840 @ctx=#<TestHelpers::FakeContext:0x00005649f264c2c8 @root="/home/runner/work/shopify-cli/shopify-cli/test/fixtures/theme", @env={"DOTNET_NOLOGO"=>"1", "DEPLOYMENT_BASEPATH"=>"/opt/runner", "USER"=>"runner", "BUNDLER_VERSION"=>"2.2.29", "CI"=>"true", "PIPX_HOME"=>"/opt/pipx", "GITHUB_ENV"=>"/home/runner/work/_temp/_runner_file_commands/set_env_f4590c6e-95ab-4cba-933e-2a358efbf36d", "JAVA_HOME_8_X64"=>"/usr/lib/jvm/adoptopenjdk-8-hotspot-amd64", "SHLVL"=>"1", "RUBYOPT"=>"-r/opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/bundler-2.2.29/lib/bundler/setup", "HOME"=>"/home/runner", "RUNNER_TEMP"=>"/home/runner/work/_temp", "GITHUB_EVENT_PATH"=>"/home/runner/work/_temp/_github_workflow/event.json", "BUNDLER_ORIG_BUNDLER_VERSION"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "JAVA_HOME_11_X64"=>"/usr/lib/jvm/adoptopenjdk-11-hotspot-amd64", "GITHUB_REPOSITORY_OWNER"=>"Shopify", "PIPX_BIN_DIR"=>"/opt/pipx_bin", "JAVA_HOME_12_X64"=>"/usr/lib/jvm/adoptopenjdk-12-hotspot-amd64", "GRADLE_HOME"=>"/usr/share/gradle-7.2", "GITHUB_RETENTION_DAYS"=>"90", "HOMEBREW_PREFIX"=>"/home/linuxbrew/.linuxbrew", "AZURE_EXTENSION_DIR"=>"/opt/az/azcliextensions", "POWERSHELL_DISTRIBUTION_CHANNEL"=>"GitHub-Actions-ubuntu18", "GITHUB_HEAD_REF"=>"", "HOMEBREW_SHELLENV_PREFIX"=>"/home/linuxbrew/.linuxbrew", "GITHUB_GRAPHQL_URL"=>"https://api.github.com/graphql", "NVM_DIR"=>"/home/runner/.nvm", "ImageVersion"=>"20211101.1", "DOTNET_SKIP_FIRST_TIME_EXPERIENCE"=>"1", "SHELLPID"=>"2301", "GITHUB_API_URL"=>"https://api.github.com", "SWIFT_PATH"=>"/usr/share/swift/usr/bin", "GOROOT_1_13_X64"=>"/opt/hostedtoolcache/go/1.13.15/x64", "RUNNER_OS"=>"Linux", "JOURNAL_STREAM"=>"9:21413", "GOROOT_1_14_X64"=>"/opt/hostedtoolcache/go/1.14.15/x64", "CHROMEWEBDRIVER"=>"/usr/local/share/chrome_driver", "RUNNER_USER"=>"runner", "GITHUB_WORKFLOW"=>"Shopify", "_"=>"/opt/hostedtoolcache/Ruby/2.6.6/x64/bin/bundle", "RUBYLIB"=>"/opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/bundler-2.2.29/lib", "GOROOT_1_15_X64"=>"/opt/hostedtoolcache/go/1.15.15/x64", "GITHUB_RUN_ID"=>"1417714922", "GOROOT_1_16_X64"=>"/opt/hostedtoolcache/go/1.16.9/x64", "ImageOS"=>"ubuntu18", "GITHUB_REF_TYPE"=>"branch", "GOROOT_1_17_X64"=>"/opt/hostedtoolcache/go/1.17.2/x64", "GITHUB_BASE_REF"=>"", "BOOTSTRAP_HASKELL_NONINTERACTIVE"=>"1", "GITHUB_ACTION_REPOSITORY"=>"", "PERFLOG_LOCATION_SETTING"=>"RUNNER_PERFLOG", "USER_PWD"=>"/home/runner/work/shopify-cli/shopify-cli", "PATH"=>"/home/runner/work/shopify-cli/shopify-cli/vendor/bundle/ruby/2.6.0/bin:/opt/hostedtoolcache/Ruby/2.6.6/x64/bin:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/home/runner/.local/bin:/opt/pipx_bin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games", "INVOCATION_ID"=>"a4124360837e413c8ffd0e02f9b26512", "RUNNER_TOOL_CACHE"=>"/opt/hostedtoolcache", "RUNNER_TRACKING_ID"=>"github_ae020f69-a0d2-4b91-acc0-d5a131f165d9", "DOTNET_MULTILEVEL_LOOKUP"=>"0", "ANT_HOME"=>"/usr/share/ant", "HOMEBREW_CELLAR"=>"/home/linuxbrew/.linuxbrew/Cellar", "AGENT_TOOLSDIRECTORY"=>"/opt/hostedtoolcache", "GITHUB_ACTION"=>"__run_3", "RUNNER_ARCH"=>"X64", "GITHUB_RUN_NUMBER"=>"550", "BUNDLER_ORIG_MANPATH"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "BUNDLE_BIN_PATH"=>"/opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/bundler-2.2.29/exe/bundle", "LANG"=>"C.UTF-8", "VCPKG_INSTALLATION_ROOT"=>"/usr/local/share/vcpkg", "XDG_CONFIG_HOME"=>"/home/runner/.config", "GITHUB_REF_NAME"=>"main", "CONDA"=>"/usr/share/miniconda", "RUNNER_NAME"=>"GitHub Actions 13", "GITHUB_REPOSITORY"=>"Shopify/shopify-cli", "GITHUB_ACTION_REF"=>"", "ANDROID_NDK_ROOT"=>"/usr/local/lib/android/sdk/ndk-bundle", "DEBIAN_FRONTEND"=>"noninteractive", "SHOPIFY_CLI_TEST"=>"1", "STATS_KEEPALIVE"=>"true", "GITHUB_ACTIONS"=>"true", "BUNDLER_ORIG_BUNDLE_BIN_PATH"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "BUNDLER_ORIG_RUBYOPT"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "GITHUB_REF_PROTECTED"=>"true", "GITHUB_JOB"=>"test", "RUNNER_PERFLOG"=>"/home/runner/perflog", "GITHUB_WORKSPACE"=>"/home/runner/work/shopify-cli/shopify-cli", "ACCEPT_EULA"=>"Y", "GEM_HOME"=>"/home/runner/work/shopify-cli/shopify-cli/vendor/bundle/ruby/2.6.0", "GITHUB_RUN_ATTEMPT"=>"1", "GITHUB_SHA"=>"40b79f40f411f3ee144694f8b3306cd7ae1fc4c0", "BUNDLER_ORIG_RB_USER_INSTALL"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "ANDROID_SDK_ROOT"=>"/usr/local/lib/android/sdk", "GITHUB_ACTOR"=>"cecyc", "GITHUB_REF"=>"refs/heads/main", "BUNDLE_GEMFILE"=>"/home/runner/work/shopify-cli/shopify-cli/Gemfile", "LEIN_HOME"=>"/usr/local/lib/lein", "BUNDLER_ORIG_GEM_HOME"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "JAVA_HOME"=>"/usr/lib/jvm/adoptopenjdk-8-hotspot-amd64", "PWD"=>"/home/runner/work/shopify-cli/shopify-cli", "RUNNER_WORKSPACE"=>"/home/runner/work/shopify-cli", "GITHUB_PATH"=>"/home/runner/work/_temp/_runner_file_commands/add_path_f4590c6e-95ab-4cba-933e-2a358efbf36d", "GEM_PATH"=>"", "HOMEBREW_NO_AUTO_UPDATE"=>"1", "ANDROID_HOME"=>"/usr/local/lib/android/sdk", "GITHUB_SERVER_URL"=>"https://github.com", "GECKOWEBDRIVER"=>"/usr/local/share/gecko_driver", "HOMEBREW_CLEANUP_PERIODIC_FULL_DAYS"=>"3650", "GITHUB_EVENT_NAME"=>"push", "LEIN_JAR"=>"/usr/local/lib/lein/self-installs/leiningen-2.9.7-standalone.jar", "HOMEBREW_REPOSITORY"=>"/home/linuxbrew/.linuxbrew/Homebrew", "CHROME_BIN"=>"/usr/bin/google-chrome", "BUNDLER_ORIG_BUNDLE_GEMFILE"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "BUNDLER_ORIG_GEM_PATH"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "BUNDLER_ORIG_PATH"=>"/opt/hostedtoolcache/Ruby/2.6.6/x64/bin:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/home/runner/.local/bin:/opt/pipx_bin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin", "SELENIUM_JAR_PATH"=>"/usr/share/java/selenium-server-standalone.jar", "ANDROID_NDK_HOME"=>"/usr/local/lib/android/sdk/ndk-bundle", "BUNDLER_ORIG_RUBYLIB"=>"BUNDLER_ENVIRONMENT_PRESERVER_INTENTIONALLY_NIL", "CLI_FRAME_STACK"=>"", "CLI_STYLE_STACK"=>""}>, @root=#<Pathname:/home/runner/work/shopify-cli/shopify-cli/test/fixtures/theme>, @id=nil, @name=nil, @role=nil>, @ignore_filter=nil, @queue=#<Thread::Queue:0x00005649f266f700>, @pending=[], @threads=[#<Thread:0x00005649f2687080@/home/runner/work/shopify-cli/shopify-cli/lib/shopify_cli/theme/syncer.rb:100 sleep_forever>, #<Thread:0x00005649f2686f40@/home/runner/work/shopify-cli/shopify-cli/lib/shopify_cli/theme/syncer.rb:100 sleep_forever>, #<Thread:0x00005649f2686e28@/home/runner/work/shopify-cli/shopify-cli/lib/shopify_cli/theme/syncer.rb:100 sleep_forever>, #<Thread:0x00005649f2686b30@/home/runner/work/shopify-cli/shopify-cli/lib/shopify_cli/theme/syncer.rb:100 sleep_forever>], @backoff_mutex=#<Thread::Mutex:0x00005649f266f660>, @delay_errors=false, @delayed_errors=[], @checksums={}> to not be empty.

Expected behavior

Test should not be flaky

Actual behavior

Test fails intermittently in CI

github-actions[bot] commented 2 years ago

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.

→ If there's no activity within a week, then a bot will automatically close this.

Thanks for helping to improve Shopify's dev tooling and experience.