Shopify / shopify-cli

Shopify CLI helps you build against the Shopify platform faster.
https://shopify.dev/tools/cli
Other
1.01k stars 202 forks source link

[Bug]: System call failed: unzip -u, BusyBox unzip has no -u flag #2213

Closed ianjosephwilson closed 1 year ago

ianjosephwilson commented 2 years ago

Please confirm that you have:

What type of project are you working on?

app

Expected behavior

ngrok.zip should download and then be unzipped without error

Actual behavior

unzip fails because there is no -u command

unzip -u /home/zing/.cache/shopify/ngrok.zip
unzip: unrecognized option: u
BusyBox v1.34.1 (2022-02-02 18:21:20 UTC) multi-call binary.

Usage: unzip [-lnojpq] FILE[.zip] [FILE]... [-x FILE]... [-d DIR]

Extract FILEs from ZIP archive

    -l  List contents (with -q for short form)
    -n  Never overwrite files (default: ask)
    -o  Overwrite
    -j  Do not restore paths
    -p  Write to stdout
    -t  Test
    -q  Quiet
    -x FILE Exclude FILEs
    -d DIR  Extract into DIR

Stack trace

shopify app tunnel start 
✓ curl @ /usr/bin/curl
✓ unzip @ /usr/bin/unzip
⠋ Installing ngrok…
┏━━ Error ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
┃ ✗ System call failed: unzip -u /home/zing/.cache/shopify/ngrok.zip


### Reproduction steps

1. install docker image
2. use shopify login to connect to shop
3. try `shopify auth tunnel auth MY_TOKEN` when following https://shopify.dev/apps/getting-started/create#step-3-start-a-local-development-server

### Operating System

alpine linux

### CLI version (run `shopify version` if you're not sure)

2.15.2

### Shell

zsh

### Ruby version (run `ruby -v` if you're not sure)

3.1.1p18

### What language and version are you using in your application?

NA
ianjosephwilson commented 2 years ago

I was able to work around this bug by going into cache directory and unzipping the file without any options to unzip.

ianjosephwilson commented 2 years ago

I'm using busybox because I'm running the CLI in a container mentioned by a user in #1282. The docker container is zingstudios/shopify-cli.

kode-emperor commented 2 years ago

Thank you very much @ianjosephwilson this worked for me.

github-actions[bot] commented 2 years ago

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.

→ If there's no activity within a week, then a bot will automatically close this.

Thanks for helping to improve Shopify's dev tooling and experience.

ianjosephwilson commented 2 years ago

I got it working but my conclusion after difficulties was to just not use shopify-cli. Glad I could help some people though. Not sure if this bug ever even got fixed.

github-actions[bot] commented 1 year ago

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.

→ If there's no activity within a week, then a bot will automatically close this.

Thanks for helping to improve Shopify's dev tooling and experience.