Shopify / shopify-cli

Shopify CLI helps you build against the Shopify platform faster.
https://shopify.dev/tools/cli
Other
1.01k stars 201 forks source link

[Enhancement]: Improve CLI Notifications #2647

Closed superfein closed 1 year ago

superfein commented 2 years ago

What type of project(s) will this request affect?

theme

Overview

I would like CLI to provide better notifications in the terminal when there are failures. Even if this means providing some basic possibilities of known/common reasons for failures to get shopify theme serve to work. For instance, it could ask if there is a folder in the assets folder, since this would cause a failure. Having as much information as possible provided by CLI directly in the terminal would be ideal.

Motivation

Recently I had made a small coding error in a liquid template file, the nesting was slightly off. The command shopify theme serve would fail, but the error message wasn't helpful at all. It just failed for an unknown reason and recommended I do a stack trace. This reminded me of Windows 98, when I would get errors like "An error of the type 407 has occurred."

Another issue I just faced today, I was logged into my client's store as my client, using their login details, but when I tried to spin up my partner development theme it failed because I was logged into my client's account and not my partner account. Obviously this was easy to troubleshoot, but still there was no helpful notification at all. Just a failure with no information at all.

github-actions[bot] commented 1 year ago

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.

→ If there's no activity within a week, then a bot will automatically close this.

Thanks for helping to improve Shopify's dev tooling and experience.