search

Shopify / shopify-cli

Shopify CLI helps you build against the Shopify platform faster.
https://shopify.dev/tools/cli
Other
1.01k stars 201 forks source link

[Feature]: Update the app so it uses the recommended method for authorizing embedded apps using OAuth (August 23, 2022 Update) #2649

Closed egillanton closed 1 year ago

egillanton commented 2 years ago

What type of project(s) will this request affect?

app

What type of change do you want to see?

Substantial change to existing feature

Overview

Based on the update announced here: https://shopify.dev/apps/auth/oauth/update/node-php

Add exitiframe functionality without removing the former code, but offer some kind of a smooth migration. I mean don't delete top-level-auth-redirect.js or the /api/auth/toplevel route, but offer the option to enable to this feature.

Motivation

I recently finished creating my public app using the Shopify CLI 2.26, I submitted it a few days ago, and I got rejected due to I didn't implement the exitiframe update.

I tried following the update post, and I failed to make it work: https://shopify.dev/apps/auth/oauth/update/node-php

The biggest challenge is to get the Exitiframe.jsx to work in my HomePage, as the app doesn't use file routing.

github-actions[bot] commented 1 year ago

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.

→ If there's no activity within a week, then a bot will automatically close this.

Thanks for helping to improve Shopify's dev tooling and experience.