[Bug]: `shopify theme serve` inconsistently syncs

brenr commented 2 years ago

Please confirm that you:

[X] Are working with Shopify CLI 2.0, not 3.0. (You can open a 3.0 issue here.)
[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

What type of project are you working on?

theme

Expected behavior

The theme should sync on changes. Whether that's through hot reloading on 127.0.0.1:9092 or by manually refreshing the store URL.

Actual behavior

The theme either syncs, or it doesn't, or when I save, it shows what the previous saved state was.

Stack trace

No response

Reproduction steps

Login with shopify login -s mystore.myshopify.com
Run shopify theme serve
Continuously make changes until you find the changes not being applied. In my case, I just made simple css changes within a snippet's {% stylesheet %} block.

Operating System

macOS Monterey 12.6 (21G115)

CLI version (run `shopify version` if you're not sure)

2.27.0

Shell

zsh

Ruby version (run `ruby -v` if you're not sure)

ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [arm64-darwin21]

What language and version are you using in your application?

Node 16.18.0

brenr commented 2 years ago

Hopefully this additional context helps:

I'm on an Apple silicon-based machine, specifically an M1 Pro.
I initially encountered this issue several months back.

nboliver commented 2 years ago

Experiencing similar behaviour. When making changes to liquid files, the changes often do not show up with hot reload, and it takes a full manual reload to see the changes. In the attached video, you can see the liquid file being changed, hot reload updating the page with no changes, and then a manual reload making the changes show:

https://user-images.githubusercontent.com/3094055/198071058-414445f3-7010-40d3-9fdc-5784c975b49a.mov

Also using Apple M1 Pro, CLI v2.29.0, Node 16.18.0, ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [arm64-darwin21] Theme uses Vite + Tailwind.

github-actions[bot] commented 1 year ago

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.

→ If there's no activity within a week, then a bot will automatically close this.

Thanks for helping to improve Shopify's dev tooling and experience.

Shopify / shopify-cli