Shopify / shopify-cli

Shopify CLI helps you build against the Shopify platform faster.
https://shopify.dev/tools/cli
Other
1.01k stars 201 forks source link

Fix for "X zip is required for packaging a theme" on Windows #2667

Closed mgmanzella closed 2 years ago

mgmanzella commented 2 years ago

WHY are these changes introduced?

Fixes https://github.com/Shopify/shopify-cli/issues/2513

WHAT is this pull request doing?

Modifies the package command to use a 7zip to zip files when theme package is run on Windows

How to test your changes?

Machine Setup

The test steps should be run on all platforms.

Mac
Windows
Linux

TODO

Test Steps

  1. If you don't have a theme available, shopify-dev theme init
  2. shopify-dev theme package <path/to/theme>
  3. Confirm zip file is generated in theme directory with theme name and version as the name
  4. Unzip the zip file and confirm only directories in THEME_DIRECTORIES are present
  5. Confirm nested folders were also included
  6. cd <theme-name>
  7. shopify-dev theme package
  8. Repeat steps 3-5

Post-release steps

Update checklist