Closed Poitrin closed 2 years ago
one more thing! i noticed when testing i select no
to not proceed and from the CLI 3, the CLI hangs and doesn't exit. I have to ctrl-C to exit the CLI. have you seen this happen? (it could also be my setup so im skeptical there's actually a bug 😅 but thought i'd mention anyway)
i noticed when testing i select
no
to not proceed and from the CLI 3, the CLI hangs and doesn't exit. I have to ctrl-C to exit the CLI. have you seen this happen? (it could also be my setup so im skeptical there's actually a bug 😅 but thought i'd mention anyway)
Thanks for highlighting this! I will take a closer look again and then potentially add changes to https://github.com/Shopify/cli/pull/743 :-)
WHY are these changes introduced?
We want to…
shopify theme share/pull/push/serve/dev
in the correct directoryWHAT is this pull request doing?
Requests a confirmation from the user to the following question …
… if users …
shopify theme share
in a directory that doesn't seem [1] like a theme directoryshopify theme serve/dev
in a directory that doesn't seem [1] like a theme directoryshopify theme push
in a directory that doesn't seem [1] like a theme directoryshopify theme pull
in a directory that doesn't seem [1] like a theme directory or it's not empty[1] https://shopify.dev/themes/architecture#directory-structure-and-component-types
How to test your changes?
No confirmation needed
Part 1:
cd
into a directory that seems like a theme directory and contains some theme files.shopify theme share/serve/push
Part 2:
cd
into an empty directory, or a directory with at least the folders%w(config layout sections templates)
shopify theme pull
Confirmation needed
Part 1:
cd
into an empty directory, or a directory that does not contain all the folders%w(config layout sections templates)
shopify theme share/serve/push
Part 2:
cd
into a non-empty directory that does not contain all the folders%w(config layout sections templates)
shopify theme pull
Post-release steps
Update shopify.dev docs, as– flag is hidden, so no need to update docs f.t.m.--force
flag has been added.Update checklist