Fix timeout issue with the `shopify theme push` command with the `--json` flag - Githubissues

Shopify / shopify-cli

Shopify CLI helps you build against the Shopify platform faster.

https://shopify.dev/tools/cli

Other

1.01k stars 201 forks source link

Fix timeout issue with the `shopify theme push` command with the `--json` flag #2683

Closed karreiro closed 2 years ago

karreiro commented 2 years ago

Fixes https://github.com/Shopify/shopify-cli/issues/2682

WHY are these changes introduced?

When users pass the --json flag, the uploader fails because it doesn't have a progress bar to update.

WHAT is this pull request doing?

Now, the Syncer::Uploader handles the progress bar as an optional dependency.

How to test your changes?

Run shopify-dev theme push -u -t abc1 --json
Notice the upload finishes

Post-release steps

None.

Update checklist

[x] I've added a CHANGELOG entry for this PR (if the change is public-facing)
[x] I've considered possible cross-platform impacts (Mac, Linux, Windows).
[x] I've left the version number as is (we'll handle incrementing this when releasing).
[x] I've included any post-release steps in the section above (if needed).