Shopify / shopify-cli

Shopify CLI helps you build against the Shopify platform faster.
https://shopify.dev/tools/cli
Other
1.01k stars 201 forks source link

Delete checksum after file deletion #2706

Closed Poitrin closed 1 year ago

Poitrin commented 1 year ago

WHY are these changes introduced?

Fixes https://github.com/Shopify/cli/issues/733

Files that get added and uploaded, then deleted (both local and remote), then added again, will not get uploaded again, because checksums are outdated.

WHAT is this pull request doing?

When a file has been successfully deleted (both local and remote), checksum in checksum store is removed, so that the same file can be reuploaded again.

How to test your changes?

  1. In a theme directory, run shopify theme serve
  2. Add a new file, e.g. index.js with content console.log('…') in the assets folder, and verify that it gets uploaded.
  3. Delete the file locally, and verify that it gets deleted remotely too.
  4. Revert the delete, and verify that it gets uploaded again.

Post-release steps

Update checklist