Shopify / shopify-cli

Shopify CLI helps you build against the Shopify platform faster.
https://shopify.dev/tools/cli
Other
1.01k stars 201 forks source link

[Bug]: Shopify CLI Requires Javscript to work #2709

Closed lukecharle closed 1 year ago

lukecharle commented 1 year ago

Please confirm that you:

What type of project are you working on?

theme

Expected behavior

Produce the response (which would be a webpage) as I'm making a fetch request

Actual behavior

I get the following in the response and not the webpage

Screenshot 2023-01-06 at 09 43 09

Stack trace

No response

Reproduction steps

  1. Fetch a webpage within the same store
  2. Check response tab

Operating System

Mac OS

CLI version (run shopify version if you're not sure)

2.28.0 (has happened across multiple versions)

Shell

No response

Ruby version (run ruby -v if you're not sure)

No response

What language and version are you using in your application?

No response

karreiro commented 1 year ago

Hi @lukecharle,

Shopify CLI 2.x requires JavaScript to power hot-reload features in the shopfy theme serve command.

Still, you may preview your theme without hot-reload features in the URL below:

demo

Thank you for reporting this! Please, let me know if I've missed something.

lukecharle commented 1 year ago

Hi @karreiro , I don't have Javascript disabled in my browser so it should be working?

karreiro commented 1 year ago

@lukecharle yes, it should be working. Could you please share which browser you're using?

Also, could share a screenshot of your browser console (or equivalent)? That would be great and it would provide much more context about this issue:

console

Thanks a lot for reporting this.

SzuJanLin commented 1 year ago

Is there any update on this issue? I'm having the same problem on app block extension

karreiro commented 1 year ago

Thank you for reporting this, @SzuJanLin.

If you don't mind, could you let us know which browser you're currently using? In case you're using a browser other than Google Chrome, would you be able to give it a try on Chrome and let us know if the issue persists?

Also, if it's possible for you to share a screenshot of your browser console (or equivalent), that would help us get a better understanding of the problem and work towards a solution. Thanks a lot!

mihrich commented 1 year ago

Check your theme.liquid

So, for example, I put instead of {% style %} and {% endstyle %} and got the same error