Closed Poitrin closed 1 year ago
Part of https://github.com/Shopify/internal-cli-foundations/issues/509 Is required by https://github.com/Shopify/cli/pull/1169
Issue https://github.com/Shopify/shopify-cli/issues/2433 was fixed with https://github.com/Shopify/shopify-cli/pull/2463. With https://github.com/Shopify/cli/pull/1169, Node CLI needs to pass Ruby CLI a hidden flag to differentiate themes created at runtime.
Introduces --overwrite-json flag that Node CLI can pass to Ruby CLI.
--overwrite-json
lib/shopify_cli/theme/theme.rb
@created_at_runtime = true
shopify(-dev) theme serve /path/to/theme --theme-editor-sync
shopify(-dev) theme serve /path/to/theme --theme-editor-sync --overwrite-json
–
WHY are these changes introduced?
Part of https://github.com/Shopify/internal-cli-foundations/issues/509 Is required by https://github.com/Shopify/cli/pull/1169
Issue https://github.com/Shopify/shopify-cli/issues/2433 was fixed with https://github.com/Shopify/shopify-cli/pull/2463. With https://github.com/Shopify/cli/pull/1169, Node CLI needs to pass Ruby CLI a hidden flag to differentiate themes created at runtime.
WHAT is this pull request doing?
Introduces
--overwrite-json
flag that Node CLI can pass to Ruby CLI.How to test your changes?
lib/shopify_cli/theme/theme.rb
, remove the line@created_at_runtime = true
, because theme will already have been created by Node CLI.shopify(-dev) theme serve /path/to/theme --theme-editor-sync
shopify(-dev) theme serve /path/to/theme --theme-editor-sync --overwrite-json
Post-release steps
–
Update checklist