search

Shopify / shopify-css-import

Add CSS import functionality to Shopify theme development with Grunt.js or Gulp.js
http://shopify.github.io/shopify-css-import
MIT License
83 stars 18 forks source link

making sure only theme.scss.liquid is copied over #17

Closed marcobarbosa closed 9 years ago

marcobarbosa commented 9 years ago

This will ensure that only theme.scss.liquid is read and copied over to assets/.

This solution probably works too but I feel that directly reading theme.scss.liquid worked best for me.

cshold commented 9 years ago

I'm partial to the same fix as the Grunt file. It gives the user a bit more power in what they can use it for, rather than strapping them into the theme.scss.liquid structure. This becomes a lot more evident when you have multiple 'base' stylesheets rather than just theme.scss.

marcobarbosa commented 9 years ago

Fair enough!

I might give it a second though later. Feel free to close this PR then :)

@MarcoBarbosa http://marcobarbosa.com

On Tue, Aug 4, 2015 at 3:20 PM, Carson Shold notifications@github.com wrote:

I'm partial to the same fix as the Grunt file. It gives the user a bit more power in what they can use it for, rather than strapping them into the theme.scss.liquid structure. This becomes a lot more evident when you have multiple 'base' stylesheets rather than just theme.scss.

— Reply to this email directly or view it on GitHub https://github.com/Shopify/shopify-css-import/pull/17#issuecomment-127607135 .