search

Shopify / shopify-css-import

Add CSS import functionality to Shopify theme development with Grunt.js or Gulp.js
http://shopify.github.io/shopify-css-import
MIT License
83 stars 18 forks source link

Update to latest Timber and some more... :) #18

Open humancopy opened 9 years ago

humancopy commented 9 years ago

Hey,

This commit updates to the latest Timber but also changes some extra stuff:

  1. Separate the grid specific mixins to _grid_mixins.scss.liquid to make it reusable
  2. Move .clearfix definition to _rest-of-styles.scss.liquid and use the clearfix mixin
  3. Upgrade some dependencies

Thanks ;)

cshold commented 9 years ago

This repo is more of an example of how structure your files, not rely on it for the most up to date Timber version. I'll add that to the readme.

Can you revise the PR to revert the Timber changes and just update the dependencies?

humancopy commented 9 years ago

I understand, but still don't you think it's better to keep this example updated so if someone wants to use it they get the latest Timber?

cshold commented 9 years ago

That means updating source code in multiple places, which definitely isn't ideal. This repo is all about the build tasks, so I'd rather keep the focus on that.

humancopy commented 9 years ago

How about making this project the source for Timber? Or even better, merging this with Timber (as a src folder) and having the build task there?

cshold commented 9 years ago

That's not on the roadmap right now, but definitely a thought we've had.

humancopy commented 9 years ago

So how about continue updating this one with Timber until it does? I don't mind being responsible on making the necessary adjustments every once in a while :)