Shopify / shopify-express

“Get up and running quickly with Express.js and the Shopify API.”
MIT License
137 stars 87 forks source link

Querystring Nesting support #90

Closed inomn closed 2 years ago

inomn commented 6 years ago

The same that https://github.com/Shopify/shopify-express/pull/67 But:

Here is original motivation by @klall

When performing a GET request for an individual asset from the Shopify Admin API I noticed there isn't support for nested query parameters.

For example performing this request: GET /admin/themes/#{id}/assets.json?asset[key]=templates/index.liquid&theme_id=828155753 (https://help.shopify.com/api/reference/asset)

results in a query string seen by the server as follows: { theme_id: '11949473849', asset: { key: 'assets/dci_locales.json' } }

However, the library querystring doesn't support nested objects and therefore the final request URL sent to shopify isn't formed properly.

It works perfectly if I swap out the querystring library with the qs library.