Delete session with repository - Githubissues

Shopify / shopify_app

A Rails Engine for building Shopify Apps

MIT License

1.74k stars 685 forks source link

Delete session with repository #1773

Closed lizkenyon closed 5 months ago

lizkenyon commented 6 months ago

What this PR does

Closes #1723

Users can customize their session storage so we cant rely on models like Shop or User

Reviewer's guide to testing

Are sessions still deleted as expected?

Things to focus on

Are sessions still deleted as expected
Do the new tests assert appropriately?
Checklist

Before submitting the PR, please consider if any of the following are needed:

[x] Update CHANGELOG.md if the changes would impact users
[ ] Update README.md, if appropriate.
[ ] Update any relevant pages in /docs, if necessary
[ ] For security fixes, the Disclosure Policy must be followed.