Changes in access scopes redirect https issues

Shopify / shopify_app

A Rails Engine for building Shopify Apps

MIT License

1.76k stars 683 forks source link

Changes in access scopes redirect https issues #1792

Closed danwetherald closed 7 months ago

danwetherald commented 7 months ago

When adding more scopes, we are seeing issues in development as follows:

HTTP parse error, malformed request: #<Puma::HttpParserError: Invalid HTTP format, parsing fails. Are you trying to open an SSL connection to a non-SSL Puma?

Looks like the redirect to /login is going to https://localhost:3000/login.

Logs

Redirected to http://localhost:3000/login?shop=..............

Browser Network:

lizkenyon commented 7 months ago

Hi there 👋

I wasn't able to reproduce this myself. Looking at the code it looks like this could be happening for a variety of reasons depending on some configurations.

Could you confirm for me

The version of the shopify_app gem that you are using?
Whether or not your app is embedded in the admin? (from the screenshots it looks like yes?)

Some areas to check in the meantime

What is your host set to in the environment file?
What is config.embedded_redirect_url

github-actions[bot] commented 7 months ago

We are closing this issue because we did not hear back regarding additional details we needed to resolve this issue. If the issue persists and you are able to provide the missing clarification we need, feel free to respond and reopen this issue.

We appreciate your understanding as we try to manage our number of open issues.