Shopify / shopify_app

A Rails Engine for building Shopify Apps
MIT License
1.74k stars 685 forks source link

Fix and Refactor splash page URL Handling to Respect Nested URLs #1794

Closed uurcank closed 4 months ago

uurcank commented 5 months ago

This PR addresses an inconsistency in the splash_page_with_params method within the controller concern, where the method previously defaulted to the application's root path, disregarding the nested URL setting as explained here.

Previously, when a nested_url was enabled and the app was accessed from the Shopify dashboard or the page was refreshed, the user was incorrectly redirected back to the app's root URL, instead of the intended Shopify app root (the nested URL).

uurcank commented 4 months ago

@paulomarg ready for merge 👍