No longer rescue non-shopify errors during OAuth - Githubissues

Shopify / shopify_app

A Rails Engine for building Shopify Apps

MIT License

1.76k stars 683 forks source link

No longer rescue non-shopify errors during OAuth #1807

Closed nelsonwittwer closed 7 months ago

nelsonwittwer commented 7 months ago

What this PR does

In the unlikely scenerio that users have customized the oauth flow and throw their own error class, we will no longer catch non-shopify API errors.

Checklist

Before submitting the PR, please consider if any of the following are needed:

[x] Update CHANGELOG.md if the changes would impact users
[x] Update README.md, if appropriate.
[x] Update any relevant pages in /docs, if necessary
[x] For security fixes, the Disclosure Policy must be followed.