Remove references to unused assets and features - Githubissues

Shopify / shopify_app

A Rails Engine for building Shopify Apps

MIT License

1.76k stars 683 forks source link

Remove references to unused assets and features #1865

Closed brendo closed 3 months ago

brendo commented 3 months ago

What this PR does

This PR is a cleanup to:

Remove non-existent references to JS files from the Rails precompile.

"shopify_app/post_redirect.js",
"shopify_app/top_level.js",
"shopify_app/enable_cookies.js",
"shopify_app/request_storage_access.js",
"storage_access.svg",

Remove the storage_access.svg
Remove unused translation keys for features that have been removed.

Most of this is related to old features such as cookies (https://github.com/Shopify/shopify_app/pull/617), which was removed in https://github.com/Shopify/shopify_app/pull/1611 (2 years ago).

Checklist

Before submitting the PR, please consider if any of the following are needed:

[x] Update CHANGELOG.md if the changes would impact users
[ ] Update README.md, if appropriate.
[ ] Update any relevant pages in /docs, if necessary
[ ] For security fixes, the Disclosure Policy must be followed.