Closed kirillplatonov closed 5 days ago
cc @zzooeeyy @paulomarg
Hi @kirillplatonov thank you for opening this PR and the others, the team will look at them soon.
@matteodepalo Thanks guys! Let me know if any adjustments are necessary.
@zzooeeyy Awesome! Resolved conflicts and ready for merge.
What this PR does
Fixes #1866
When app root URL is opened directly outside of iframe it used to redirect to
/login
page. With Token Exchange auth it now throws an exceptionShopifyAPI::Errors::MissingJwtTokenError
becausecurrent_shopify_domain
method is called byShopifyApp::FrameAncestors
and it doesn't have any error handling at the moment.In this PR I added missing error handling for
current_shopify_domain
and redirect to/login
work again. https://github.com/Shopify/shopify_app/assets/839922/da1eb29c-1f7f-4f26-b8ea-637778cfd8b0Reviewer's guide to testing
To reproduce the issue:
ShopifyAPI::Errors::MissingJwtTokenError
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.md
if the changes would impact usersREADME.md
, if appropriate./docs
, if necessary