Shopify / shopify_app

A Rails Engine for building Shopify Apps
MIT License
1.74k stars 683 forks source link

Keep original path and params when redirecting deep links to embed #1869

Closed kirillplatonov closed 5 days ago

kirillplatonov commented 2 weeks ago

What this PR does

Fixes deep link behavior to make sure the original path and params are preserved after redirect to app embed. Right now all deep links are redirected to home page. In addition to deep links it fixes opening links in new tab in app embed.

https://github.com/Shopify/shopify_app/assets/839922/a1c43f6a-8486-40ea-af4c-5ef384906807

Checklist

Before submitting the PR, please consider if any of the following are needed:

kirillplatonov commented 1 week ago

cc @zzooeeyy @paulomarg

kirillplatonov commented 5 days ago

@matteodepalo resolved changelog conflict. Ready for merge