search

Shopify / shopify_app

A Rails Engine for building Shopify Apps
MIT License
1.76k stars 684 forks source link

Script Tags are not being registered #1891

Open jagthedrummer opened 1 month ago

jagthedrummer commented 1 month ago

Issue summary

Before opening this issue, I have:

When a shop installs the app the scripttags specified in the initializer aren't registered.

Expected behavior

The scripttags listed in the initializer should be registered.

Actual behavior

They are not registered.

Steps to reproduce the problem

  1. Install an app with scripttags in a new shop.
  2. See that the script tag is not registered.

It looks like maybe something on the Shopify side broke this starting sometime in mid June.

I realize that script tags are deprecated, but all of the info I can find says that they should continue to work until August of 2025.

matteodepalo commented 1 month ago

Hi @jagthedrummer thank you for opening this we can take a look.

lizkenyon commented 1 month ago

Hey there @jagthedrummer!

The script tag manager was removed in version 22. In the upgrading guide you can find our recommendation.

I do see that we still have the scripttags configuration in the shopifyApp object, so I can understand where the confusion is coming from. The team will look into clarifying this.

jagthedrummer commented 1 month ago

@lizkenyon, I see.

FWIW, as a developer working in the Shopify ecosystem I feel it's pretty unfriendly (bordering on hostile) to purposefully remove working code over a full calendar year before the functionality supported by that code is slated to be dropped.

lizkenyon commented 1 month ago

I think that is very valid feedback. I will share with the team.

jagthedrummer commented 1 day ago

@lizkenyon Any word on this? It would be great to have the ScriptManager added back since that feature isn't actually deprecated yet.