search

Shopify / shopify_python

Python development standards at Shopify
MIT License
65 stars 13 forks source link

Test that all message names that a linter defines are added #45

Closed cfournie closed 7 years ago

cfournie commented 7 years ago

To prevent https://github.com/Shopify/shopify_python/issues/43 from reoccurring, we should add a test to ensure that the set of message names that a linter uses in add_message calls is equivalent to the message names in the linter's msgs variable.

We could use integration tests to accomplish this, e.g. https://github.com/Shopify/pylint/commit/1f85e3c32b226740cba32f792bfd66a6e6c34dbe

cfournie commented 7 years ago

Specifically, we want to be able to assemble a directory like this with functional tests for each of our custom rules and adapt this functional test generation code to generate py.test tests for each set of functional test files.