search

Shopify / shopify_python_api

ShopifyAPI library allows Python developers to programmatically access the admin section of stores
http://shopify.github.io/shopify_python_api
MIT License
1.23k stars 349 forks source link

Shopify Python SDK Deletes Customer Address on Same Address Update #708

Closed nh916 closed 3 weeks ago

nh916 commented 5 months ago

Description

When using the Shopify Python SDK with GraphQL to update a customer's default address, I've noticed that the the SDK deletes the existing address if the update request contains the same address details as the existing one. This behavior results in unexpected address deletion and can lead to data loss for Shopify merchants.

Steps to Reproduce

  1. Update a customer's default address using the Shopify Python SDK.
  2. Use the same address details in the update request as the existing default address.
  3. Execute the update request.

Expected Behavior

The Shopify Python SDK should not delete the existing address if the update request contains the same address details as the existing one. Instead, it should preserve the existing address without making any changes.

Actual Behavior

The Shopify Python SDK deletes the existing address when the update request contains the same address details as the existing one.

Workaround

As a workaround, users can manually check every field if the new address details are different from the existing default address before sending the update request. If the details are the same, they can skip the update request to avoid unintentional address deletion. levant documentation or references]

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

nh916 commented 3 months ago

please keep it open as it is a real issue

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

github-actions[bot] commented 3 weeks ago

We are closing this issue because it has been inactive for a few months. This probably means that it is not reproducible or it has been fixed in a newer version. If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.

If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines

Thank you!