search

Shopify / shopify_theme

A console tool for interacting with Shopify Theme Assets.
http://shopify.github.io/shopify_theme
MIT License
645 stars 135 forks source link

Provide callback for when assets complete or if upload times out for some reason #154

Closed mpiotrowicz closed 9 years ago

mpiotrowicz commented 9 years ago

cc @cshold @stevebosworth anything else required?

cshold commented 9 years ago

I'd just make sure all assets are done uploading as multiple can be changed/saved/created at a time. A callback after theme replace would be nice too.

csaunders commented 9 years ago

https://github.com/csaunders/themekit/pull/51

mpiotrowicz commented 9 years ago

we're currently still using the theme gem, any hope of updating it here?

csaunders commented 9 years ago

Now that shopify owns themekit, is still still a concern?

mpiotrowicz commented 9 years ago

@cshold @stevebosworth

stevebosworth commented 9 years ago

If we're committed to actively working on themekit and sunsetting the gem, I'm fine with leaving this as is. if that's still a ways off it would be great to get this available in the gem.

csaunders commented 9 years ago

Let's get a milestone rolling on themekit and start adding the missing features that are blocking you from using it for realz.

On Tue, Sep 1, 2015 at 3:41 PM, Steve Bosworth notifications@github.com wrote:

If we're committed to actively working on themekit and sunsetting the gem, I'm fine with leaving this as is. if that's still a ways off it would be great to get this available in the gem.

— Reply to this email directly or view it on GitHub https://github.com/Shopify/shopify_theme/issues/154#issuecomment-136837244 .

Chris Saunders // Developer @ Shopify

csaunders commented 9 years ago

Here's our milestone.

Anything else you can think of?

Should administrative things go in there as well (updating documentation, etc)?

/cc @fredryk

cshold commented 9 years ago

:+1: can be closed in favour of going ahead on themekit.