search

Shopify / shopify_theme

A console tool for interacting with Shopify Theme Assets.
http://shopify.github.io/shopify_theme
MIT License
645 stars 135 forks source link

Old version of Timber gets downloaded when no version specified #201

Open jonscottclark opened 8 years ago

jonscottclark commented 8 years ago

I tried the bootstrap command without specifying --version=master or --version=latest and it seemed to give me an outdated version of timber. There wasn't even the extra timber.scss.liquid file that appears with the master release, just a theme.scss.liquid file.

I have no way of knowing how old the theme is, unfortunately, but it should be easily reproducible.

Should the default value of --version be master so that users always get the latest release?

jonscottclark commented 8 years ago

Actually, even --version=latest and --version=master seems to be an old version. It includes jquery.flexslider.min.js in the /assets folder, for instance, if that helps. A brief look through releases and I can't find it in any of them.. so exactly what is this gem grabbing, and why Timber up to date?

jonscottclark commented 8 years ago

I can see that if I specify master as the version then it should download https://github.com/Shopify/Timber/archive/master.zip, and I downloaded that manually — but that's not what gets downloaded by the gem, is there some caching issue happening, perhaps?