Convert special_price smartly to make compare_at_price work as expected

Shopify / shopify_transporter

The Transporter tool allows you to convert data from a third-party platform into a format that can be imported into Shopify.

MIT License

98 stars 43 forks source link

Convert special_price smartly to make compare_at_price work as expected #119

Closed JordanVerasamy closed 6 years ago

JordanVerasamy commented 6 years ago

What it does and why:

Converts Magento special_price into Shopify's compare_at_price properly.

Demo

In Magento:

In Shopify:

Checklist:

[x] Testing & QA: Passes tests and linting.
[x] :tophat:: I have manually tested these changes.

Related issues:

Closes:

https://github.com/Shopify/shopify_transporter/issues/109

JordanVerasamy commented 6 years ago

^ Turns out this is much more ambiguous than we thought, because of the fact that parent products can have prices and special prices as well and these override the child's.