[R] force user to pass along scheme prefix in hostname

Shopify / shopify_transporter

The Transporter tool allows you to convert data from a third-party platform into a format that can be imported into Shopify.

MIT License

98 stars 43 forks source link

[R] force user to pass along scheme prefix in hostname #120

Closed JordanVerasamy closed 6 years ago

JordanVerasamy commented 6 years ago

What it does and why:

Instead of passing magento-sandbox.myshopify.io as the hostname, pass https://magento-sandbox.myshopify.io instead. This allows users to specify either http or https as their transfer protocol, for example.

Checklist:

[x] Testing & QA: Passes tests and linting.
[x] :tophat:: I have manually tested these changes.

Related issues:

Closes:

surajreddy commented 6 years ago

I think this should be a major version bump as it will break compatibility with older config files.

Alternatively, we could check whether the url has http[s] in it already and only append https if it is not already in the url. This would maintain compatibility with existing config files.

Thoughts?

JordanVerasamy commented 6 years ago

I'm not too keen on making ultra smart config file readers when we have lots of other more impactful work. I'm ok with a slightly breaking change as long as theres a bold sentence in the changelog. CMV.