Shopify / shopify_transporter

The Transporter tool allows you to convert data from a third-party platform into a format that can be imported into Shopify.
MIT License
98 stars 43 forks source link

Enhance the check for merging child line item into parent line item #128

Closed zliu1020-zz closed 5 years ago

zliu1020-zz commented 5 years ago

This bug has been reported from three different sources: Michael Wolz, One Rockwell and Pointer.

What it does and why:

Merge the child line item into the parent line item only when:

Checklist:

Demo:

When a configurable line item and a simple line item with 0 price share the same sku, they are combined into one line item:

screen shot 2018-12-12 at 1 26 17 pm

When two configurable line items share the same sku, they will not be merged:

In this example both have the same price

screen shot 2018-12-12 at 1 28 37 pm

When two simple line items share the same sku, they will not be merged:

In this example they have different prices

screen shot 2018-12-12 at 1 29 41 pm

When a configurable line item and a simple line item with positive price share the same sku, they will not be merged:

screen shot 2018-12-12 at 1 31 07 pm

Related issues:

Closes: https://github.com/Shopify/shopify_transporter/issues/123

JordanVerasamy commented 5 years ago

🎩 looks like this solves @michaelwolz's issue properly. (https://github.com/Shopify/shopify_transporter/issues/123)