Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 364 forks source link

Slate not watching header.liquid #1004

Closed masterShake closed 5 years ago

masterShake commented 5 years ago

npm start is triggering browser sync just fine and most of my files (templates, css, js) are being watched except section/header.liquid

Any idea how I can add this file to the watch list?

YourWishes commented 5 years ago

I'm noticing this for all sections after beta 16.

Maurice-JB commented 5 years ago

Same. Liquid files in sections\ folder not being watched. Due to changes from #1000?

dan-gamble commented 5 years ago

Does it work if you use the new convention of section/header/template.liquid and section/header/schema.json?

dan-gamble commented 5 years ago

Unfortunately, this is happening for everything inside sections including the new stuff.

I appreciate Slate has been put in low maintenance now but releasing a slightly broken release can hopefully be rectified before this low maintenance kicks into full effect @t-kelly @chrisberthe @wizardlyhel?

wizardlyhel commented 5 years ago

Thank you @dan-gamble for the PR

dan-gamble commented 5 years ago

Happy to help @wizardlyhel 😊

harshal317 commented 5 years ago

Fixed in #1005

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.